Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined sync status reporting in tray icon #5565

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

claucambra
Copy link
Collaborator

Also includes some nice clean ups

@claucambra claucambra self-assigned this Apr 4, 2023
@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

src/gui/folderman.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the bugfix/tray-sync-status-fix branch from 6ec2190 to 170b9f4 Compare May 26, 2023 02:15
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #5565 (170b9f4) into master (3dc583c) will decrease coverage by 0.44%.
Report is 198 commits behind head on master.
The diff coverage is n/a.

❗ Current head 170b9f4 differs from pull request most recent head d52ad2d. Consider uploading reports for the commit d52ad2d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5565      +/-   ##
==========================================
- Coverage   60.79%   60.36%   -0.44%     
==========================================
  Files         145      143       -2     
  Lines       18836    18518     -318     
==========================================
- Hits        11451    11178     -273     
+ Misses       7385     7340      -45     

see 60 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien force-pushed the bugfix/tray-sync-status-fix branch from 170b9f4 to d52ad2d Compare February 13, 2024 13:05
@mgallien
Copy link
Collaborator

/backport to stable-3.12

@mgallien mgallien merged commit 6797a57 into master Feb 13, 2024
10 of 13 checks passed
@mgallien mgallien deleted the bugfix/tray-sync-status-fix branch February 13, 2024 13:06
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5565-d52ad2d27bc1dbd9ea9a25c995111f63410c40b1-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants